[libvirt] [PATCHv7 4/4] qemu: Add support for networked disks for block pull/block rebase

Peter Krempa pkrempa at redhat.com
Tue Jul 8 09:59:18 UTC 2014


On 07/08/14 00:44, Eric Blake wrote:
> On 07/04/2014 05:22 AM, Peter Krempa wrote:
>> Now that we are able to select images from the backing chain via indexed
>> access we should also convert possible network sources to
>> qemu-compatible strings before passing them to qemu.
>> ---
>>  src/qemu/qemu_driver.c | 45 +++++++++++++++++++++++++++++++++++++++++----
>>  1 file changed, 41 insertions(+), 4 deletions(-)
>>
> 
>> @@ -15027,6 +15029,13 @@ qemuDomainBlockJobImpl(virDomainObjPtr vm,
>>          goto cleanup;
>>      }
>>
>> +    if (flags & VIR_DOMAIN_BLOCK_REBASE_RELATIVE && !base) {
>> +        virReportError(VIR_ERR_INVALID_ARG, "%s",
>> +                       _("flag VIR_DOMAIN_BLOCK_REBASE_RELATIVE is valid only "
>> +                         " with non-null base "));
> 
> double space and trailing space in the resulting error string.
> 
> Should we hoist this check into libvirt.c, or is there a chance that
> some other driver may support the combination?  But we can make that
> decision in a followup patch if we decide to do it.

Well looks like it won't be ever supported so we might move it to the
lib. I'll post a followup to provide a place for the discussion.

> 
> ACK with the spacing fixed.
> 

I've fixed the nits pointed out and pushed the series. Thanks.

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140708/393b5794/attachment-0001.sig>


More information about the libvir-list mailing list