[libvirt] [libvirt-glib 1/3] Add gvir_config_capabilities_cpu_get_model()

Zeeshan Ali (Khattak) zeeshanak at gnome.org
Mon Jul 14 13:56:18 UTC 2014


On Mon, Jul 14, 2014 at 10:44 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> On Tue, Jul 08, 2014 at 07:41:55PM +0100, Zeeshan Ali (Khattak) wrote:
>> On Mon, Jul 7, 2014 at 12:09 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
>> > This is returning a char *
>> > <capabilities>
>> >   <host>
>> >     <cpu>
>> >       <model>xxx</model>
>> >     </cpu>
>> >   </host>
>> > </capabilities>
>> > while the next patch exposes the model from the /domain/cpu/model node
>> > as an actual object, why the difference?
>>
>> Because /domain/cpu/model node has at least one attribute and hence a
>> simple char * won't do there.
>
> My question was the opposite one, why return a char * here instead of an
> actual object since you have to add it anyway?

Ah so you mean that I use the same object to represent both? I'm not
sure that makes sense since they are part of different XMLs and
therefore different entities. I'm not sure here.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/




More information about the libvir-list mailing list