[libvirt] [REPOST 4/8] scsi_backend: Use existing LINUX_SYSFS_SCSI_HOST_PREFIX definition

Michal Privoznik mprivozn at redhat.com
Fri Jul 18 14:30:44 UTC 2014


On 08.07.2014 13:54, John Ferlan wrote:
> Rather than supplying the path again in the formatting of the sysfs
> scsi_host directory.
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>   src/storage/storage_backend_scsi.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/storage/storage_backend_scsi.c b/src/storage/storage_backend_scsi.c
> index b5dbe51..e42778f 100644
> --- a/src/storage/storage_backend_scsi.c
> +++ b/src/storage/storage_backend_scsi.c
> @@ -475,7 +475,8 @@ virStorageBackendSCSITriggerRescan(uint32_t host)
>
>       VIR_DEBUG("Triggering rescan of host %d", host);
>
> -    if (virAsprintf(&path, "/sys/class/scsi_host/host%u/scan", host) < 0) {
> +    if (virAsprintf(&path, "%s/host%u/scan",
> +                    LINUX_SYSFS_SCSI_HOST_PREFIX, host) < 0) {
>           retval = -1;
>           goto out;
>       }
> @@ -663,7 +664,8 @@ virStorageBackendSCSICheckPool(virConnectPtr conn ATTRIBUTE_UNUSED,
>       if (getHostNumber(name, &host) < 0)
>           goto cleanup;
>
> -    if (virAsprintf(&path, "/sys/class/scsi_host/host%d", host) < 0)
> +    if (virAsprintf(&path, "%s/host%d",
> +                    LINUX_SYSFS_SCSI_HOST_PREFIX, host) < 0)
>           goto cleanup;
>
>       *isActive = virFileExists(path);
>

Huh, it's been defined, but not used anywhere till now. :)

Michal




More information about the libvir-list mailing list