[libvirt] [REPOST 0/8] storage_scsi: Stable SCSI host addressing

[John Ferlan]

On 07/18/2014 10:30 AM, Michal Privoznik wrote:
> On 08.07.2014 13:54, John Ferlan wrote:
>> Reposting of a series from last month changing only the span version
>> in the docs from 1.2.6 to 1.2.7. Previous posting here:
>>
>>    http://www.redhat.com/archives/libvir-list/2014-June/msg00448.html
>>
>> The concept still remains the same - rather than rely on the hostNN
>> numbers for the scsi_host to remain stable and unique across host reboots
>> and/or kernel rebuilds, allow use a combination of the scsi_host's PCI
>> address and the value from the hostNN's 'unique_id' file.
>>
>>
>> John Ferlan (6):
>>    getAdapterName: check for SCSI_HOST
>>    scsi_backend: Use existing LINUX_SYSFS_SCSI_HOST_PREFIX definition
>>    virutil: Introduce virReadSCSIUniqueId
>>    Add unique_id to nodedev output
>>    scsi_host: Introduce virFindSCSIHostByPCI
>>    getAdapterName: Lookup stable scsi_host
>>
>> Osier Yang (2):
>>    virStoragePoolSourceAdapter: Refine the SCSI_HOST adapter name
>>    storage: Introduce parentaddr into virStoragePoolSourceAdapter
>>
>>   docs/formatnode.html.in                            |  11 +
>>   docs/formatstorage.html.in                         | 143 ++++++++--
>>   docs/schemas/basictypes.rng                        |  24 +-
>>   docs/schemas/nodedev.rng                           |   6 +
>>   src/conf/node_device_conf.c                        |  23 +-
>>   src/conf/node_device_conf.h                        |   1 +
>>   src/conf/storage_conf.c                            | 111 +++++++-
>>   src/conf/storage_conf.h                            |   8 +-
>>   src/libvirt_private.syms                           |   2 +
>>   src/node_device/node_device_linux_sysfs.c          |   6 +
>>   src/phyp/phyp_driver.c                             |   8 +-
>>   src/storage/storage_backend_scsi.c                 |  53 +++-
>>   src/test/test_driver.c                             |   5 +-
>>   src/util/virutil.c                                 | 154 +++++++++++
>>   src/util/virutil.h                                 |   8 +
>>   tests/Makefile.am                                  |   7 +
>>   .../pci_8086_27c5_scsi_host_0_unique_id.xml        |   8 +
>>   tests/nodedevxml2xmltest.c                         |   1 +
>>   tests/scsihosttest.c                               | 308 +++++++++++++++++++++
>>   .../pool-scsi-type-scsi-host-stable.xml            |  19 ++
>>   .../pool-scsi-type-scsi-host-stable.xml            |  22 ++
>>   tests/storagepoolxml2xmltest.c                     |   1 +
>>   22 files changed, 868 insertions(+), 61 deletions(-)
>>   create mode 100644 tests/nodedevschemadata/pci_8086_27c5_scsi_host_0_unique_id.xml
>>   create mode 100644 tests/scsihosttest.c
>>   create mode 100644 tests/storagepoolxml2xmlin/pool-scsi-type-scsi-host-stable.xml
>>   create mode 100644 tests/storagepoolxml2xmlout/pool-scsi-type-scsi-host-stable.xml
>>
> 
> ACK series, but please see my inline comments.
> 
> Michal
> 

Thanks for the review.

Adjusted to add error message from 5/8...

Just pushed (now that the power supply for my fiber connection has been
replaced... funny how the kids noticed it first - Dad - the internet is
lost...)

John