[libvirt] [PATCH] storage: logical: drop useless if

Roman Bogorodskiy bogorodskiy at gmail.com
Mon Jul 21 18:32:09 UTC 2014


  John Ferlan wrote:

> On 07/21/2014 01:39 PM, Roman Bogorodskiy wrote:
> > virStorageBackendLogicalCreateVol contains a piece like:
> > 
> >     if (vol->target.path != NULL) {
> >         /* A target path passed to CreateVol has no meaning */
> >         VIR_FREE(vol->target.path);
> >     }
> > 
> > The 'if' is useless here, but 'syntax-check' doesn't catch that
> > because of the comment, so drop the 'if'.
> > ---
> >  src/storage/storage_backend_logical.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> 
> ACK

Thanks; pushed.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140721/c459eff3/attachment-0001.sig>


More information about the libvir-list mailing list