[libvirt] [PATCHv2 0/2] Tri-state bool enum cleanups

Ján Tomko jtomko at redhat.com
Wed Jul 23 11:02:49 UTC 2014


On 07/16/2014 10:34 AM, Ján Tomko wrote:
> v2: better names
>     move to virutil and use them in network_conf and device_conf too
> 
> Ján Tomko (2):
>   Introduce virTristateBool enum type
>   Introduce virTristateSwitch enum
> 
>  src/conf/device_conf.c      |   8 +-
>  src/conf/device_conf.h      |  10 ---
>  src/conf/domain_conf.c      | 202 +++++++++++++++-----------------------------
>  src/conf/domain_conf.h      | 116 ++-----------------------
>  src/conf/network_conf.c     |  11 +--
>  src/conf/network_conf.h     |  15 +---
>  src/libvirt_private.syms    |  28 +-----
>  src/libxl/libxl_conf.c      |   6 +-
>  src/lxc/lxc_container.c     |   4 +-
>  src/lxc/lxc_native.c        |   2 +-
>  src/network/bridge_driver.c |   3 +-
>  src/qemu/qemu_command.c     |  90 ++++++++++----------
>  src/qemu/qemu_driver.c      |   4 +-
>  src/qemu/qemu_process.c     |   2 +-
>  src/util/virutil.c          |  11 +++
>  src/util/virutil.h          |  21 +++++
>  src/vbox/vbox_tmpl.c        |  22 ++---
>  src/xenxs/xen_sxpr.c        |  20 ++---
>  src/xenxs/xen_xm.c          |  20 ++---
>  19 files changed, 200 insertions(+), 395 deletions(-)
> 

I've adjusted the comments I missed, added missing BIOSUseSerial to the commit
message, added a comment about the silent "yes" as default to
virNetworkDNSDefFormat, resolved the conflicts when rebasing against master
and pushed the series.

Thanks for the reviews!

Jan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140723/224a6c6f/attachment-0001.sig>


More information about the libvir-list mailing list