[libvirt] [PATCH v2 2/6] qemu: Utilize virFileFindHugeTLBFS

[Daniel P. Berrange]

On Wed, Jul 23, 2014 at 05:37:18PM +0200, Michal Privoznik wrote:
> Notes:
>     Yes, the libvirtd_qemu.aug change is missing here. The reason is prosaic: I
>     don't know how to make augeas accept both array of string and a single string
>     for a configuration variable. BTW: the security_drivers which does exactly what
>     I'm doing here, accepts only single string in the aug file too.

Hmm, I'll look into that.

> diff --git a/src/Makefile.am b/src/Makefile.am
> index 982f63d..2444d51 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1209,10 +1209,10 @@ libvirt_driver_qemu_impl_la_CFLAGS = \
>  		$(AM_CFLAGS)
>  libvirt_driver_qemu_impl_la_LDFLAGS = $(AM_LDFLAGS)
>  libvirt_driver_qemu_impl_la_LIBADD = $(CAPNG_LIBS) \
> -                                $(GNUTLS_LIBS) \
> -				$(LIBNL_LIBS) \
> -				$(LIBXML_LIBS) \
> -				$(NULL)
> +        $(GNUTLS_LIBS) \
> +        $(LIBNL_LIBS) \
> +        $(LIBXML_LIBS) \
> +        libvirt_util.la

This is a sign of something missing in libvirt_private.syms
and so should not be required.

>  libvirt_driver_qemu_impl_la_SOURCES = $(QEMU_DRIVER_SOURCES)
>  
>  conf_DATA += qemu/qemu.conf
> @@ -1995,8 +1995,8 @@ endif WITH_DRIVER_MODULES
>  BUILT_SOURCES += libvirt_probes.h libvirt_probes.stp libvirt_functions.stp
>  
>  if WITH_QEMU
> -libvirt_driver_qemu_la_LIBADD += libvirt_qemu_probes.lo
> -nodist_libvirt_driver_qemu_la_SOURCES = libvirt_qemu_probes.h
> +libvirt_driver_qemu_impl_la_LIBADD += libvirt_qemu_probes.lo libvirt_probes.lo
> +libvirt_driver_qemu_impl_la_SOURCES += libvirt_qemu_probes.h

Dunno why this was needed ???

> @@ -753,37 +753,33 @@ qemuStateInitialize(bool privileged,

>  
> -        if (virFileMakePath(mempath) < 0) {
> +        if (virFileMakePathWithMode(hugepagePath, 1777) < 0) {

Default value is '0777' - why do we need to set the sticky
bit now, when we didn't previously ?

If we need this, perhaps it should be done as a separate patch


ACK with those things fixed

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|