[libvirt] [PATCH v2] maint: prohibit empty first lines

[Michal Privoznik]

On 04.06.2014 15:01, Martin Kletzander wrote:
> Based on discussion with Eric:
>
> https://www.redhat.com/archives/libvir-list/2014-March/msg01001.html
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
> v2:
>   - rebase on current master and s/FILENAME:1:/FILENAME ":1:"/
>
>   cfg.mk | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/cfg.mk b/cfg.mk
> index 675af21..80440b5 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -938,6 +938,13 @@ sc_require_locale_h:
>   		fi;															\
>   	done;
>
> +sc_prohibit_empty_first_line:
> +	@awk 'BEGIN { fail=0; }                                        \
> +	FNR == 1 { if ($$0 == "") { print FILENAME ":1:"; fail=1; } }     \
> +	END { if (fail == 1) {                                         \
> +	  print "$(ME): Prohibited empty first line" > "/dev/stderr";  \
> +	} exit fail; }' $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$');

Maybe we can check the whole VC_LIST, there are only a few files that 
start with an empty line (typically README.txt) and those can have an 
exception. But there are some that shouldn't start with an empty line, e.g.:
docs/generic.css:1:
src/locking/lockd.conf:1:
src/locking/sanlock.conf:1:

and some testdata under 
tests/nodeinfodata/linux-test3/node/node*/meminfo. These in particular 
should be plain copy of their origins in sysfs which at least on my 
system doesn't start with an empty line:

# head -n1 /sys/devices/system/node/node0/meminfo
Node 0 MemTotal:        4004132 kB

But your version is good too. ACK whether you decide to change it the 
way I'm suggesting or not.

Michal