[libvirt] [PATCH 1/6] conf, schema: add 'id' field for cells

[Daniel P. Berrange]

On Wed, Jun 04, 2014 at 04:56:27PM +0200, Martin Kletzander wrote:
> In XML format, by definition, order of fields should not matter, so
> oder of parsing the elements doesn't affect the end result.  When
> specifying guest NUMA cells, we depend only on the order of the 'cell'
> elements.  With this patch all older domain XMLs are parsed as before,
> but with the 'id' attribute they are parsed and formatted according to
> that field.  This will be useful when we have tuning settings for
> particular guest NUMA node.
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  docs/formatdomain.html.in                          | 11 +++---
>  docs/schemas/domaincommon.rng                      |  5 +++
>  src/conf/cpu_conf.c                                | 39 +++++++++++++++++++---
>  tests/qemuxml2argvdata/qemuxml2argv-cpu-numa1.xml  |  6 ++--
>  tests/qemuxml2argvdata/qemuxml2argv-cpu-numa2.xml  |  6 ++--
>  tests/qemuxml2argvdata/qemuxml2argv-cpu-numa3.xml  | 25 ++++++++++++++
>  tests/qemuxml2argvtest.c                           |  1 +
>  .../qemuxml2xmlout-cpu-numa1.xml                   | 28 ++++++++++++++++
>  .../qemuxml2xmlout-cpu-numa2.xml                   | 28 ++++++++++++++++
>  tests/qemuxml2xmltest.c                            |  3 ++
>  10 files changed, 138 insertions(+), 14 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-numa3.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-numa1.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-cpu-numa2.xml

ACK

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|