[libvirt] [PATCH 2/6] conf, schema: add support for numatune memnode element

[Martin Kletzander]

On Wed, Jun 04, 2014 at 04:07:06PM +0100, Daniel P. Berrange wrote:
>On Wed, Jun 04, 2014 at 04:56:28PM +0200, Martin Kletzander wrote:
>> @@ -43,9 +43,17 @@ typedef virNumaTuneDef *virNumaTuneDefPtr;
>>  struct _virNumaTuneDef {
>>      struct {
>>          virBitmapPtr nodemask;
>> -        int mode;
>> +        int mode;           /* enum virDomainNumatuneMemMode */
>>          int placement_mode; /* enum virNumaTuneMemPlacementMode */
>> -    } memory;
>> +    } memory;               /* pinning for all the memory */
>> +
>> +    struct mem_node {
>
>Declaring structs inline without typedefs isn't our usual style. There
>should be a typedef for virNumaTuneMemNodeDef & virNumaTuneMemNodeDefPtr
>

Yeah, it should.  Also the numatunedef should be in some conf/ file
with encapsulated insides.  Parsing should be in that file too, of
course.

I took the liberty of proposing it this way and re-factoring
afterwards since all those details were drafting me away of the thing
I wanted to make out of that.  However, I forgot to mention that the
same way I forgot to mention that virGetNumaNodeParameters() API will
follow even though is not part of this patch.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140604/706391fb/attachment-0001.sig>