[libvirt] [libvirt-glib PATCH] Add API to get security models from host capabilities

Daniel P. Berrange berrange at redhat.com
Thu Jun 5 09:37:09 UTC 2014


On Thu, Jun 05, 2014 at 11:32:22AM +0200, Christophe Fergeau wrote:
> Hey,
> 
> Looks good to me.
> There's a 'Nuernberg' typo in the copyright lines
> I'm wondering if GVirConfigCapabilitiesSecmodel should be
> GVirConfigCapabilitiesHostSecmodel as this is only available under the
> host node.

Yes, makes sense.

> Also, libvirt uses the spelling SecModel/secmodel, might be nice to
> follow that (or SecModel/sec_model ?) 

Yes, since 'secmodel' is an abbreviation for 'Security model' both
the 'S' and 'M' should be capitalized.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list