[libvirt] [PATCH] qemu: Add cmd_per_lun, max_sectors to virtio-scsi

[Ján Tomko]

On 05/23/2014 12:06 AM, Eric Blake wrote:
> On 05/22/2014 12:22 PM, Mike Perez wrote:
>> This introduces two new attributes "cmd_per_lun" and "max_sectors" same
>> with the names QEMU uses for virtio-scsi. An example of the XML:
>>
>> <controller type='scsi' index='0' model='virtio-scsi' cmd_per_lun='50'
>> max_sectors='512'/>
> 
> I'm not a fan of underscore (why type the shift key, when a dash will
> do).  The libvirt xml name does not have to exactly match the qemu
> option name, so maybe there's some room for bikeshedding what names we
> should actually present to the user.
> 

IMO using underscores here would be consistent with other disk-related options
like read_iops_sec; dashes are mostly used for network-related options.

We could also use camelCase [1], or just roll a dice.

Jan

[1] http://www.redhat.com/archives/libvir-list/2013-April/msg01340.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140605/5cc3cc29/attachment-0001.sig>