[libvirt] [PATCH 3/3] Fix storage format probing

Ján Tomko jtomko at redhat.com
Thu Jun 5 17:11:15 UTC 2014


Commit fff74b2 moved the probing into virStorageFileGetMetadataFromBuf
but didn't update the format in volume definition.

https://bugzilla.redhat.com/show_bug.cgi?id=1104908
---
 src/storage/storage_backend_fs.c      | 2 ++
 src/storage/storage_backend_gluster.c | 1 +
 2 files changed, 3 insertions(+)

diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
index 133e059..c93fc1e 100644
--- a/src/storage/storage_backend_fs.c
+++ b/src/storage/storage_backend_fs.c
@@ -104,6 +104,8 @@ virStorageBackendProbeTarget(virStorageSourcePtr target,
     /* Default to success below this point */
     ret = 0;
 
+    target->format = meta->format;
+
     if (*backingStore &&
         *backingStoreFormat == VIR_STORAGE_FILE_AUTO &&
         virStorageIsFile(*backingStore)) {
diff --git a/src/storage/storage_backend_gluster.c b/src/storage/storage_backend_gluster.c
index 3db4e66..b96d116 100644
--- a/src/storage/storage_backend_gluster.c
+++ b/src/storage/storage_backend_gluster.c
@@ -298,6 +298,7 @@ virStorageBackendGlusterRefreshVol(virStorageBackendGlusterStatePtr state,
                                                   &vol->backingStore.format)))
         goto cleanup;
 
+    vol->target.format = meta->format;
     if (vol->backingStore.path &&
         vol->backingStore.format < 0)
         vol->backingStore.format = VIR_STORAGE_FILE_RAW;
-- 
1.8.3.2




More information about the libvir-list mailing list