[libvirt] [PATCH 2/4] storage: renumber lookup tests

Eric Blake eblake at redhat.com
Mon Jun 16 15:35:05 UTC 2014


On 06/16/2014 01:36 AM, Peter Krempa wrote:
> On 06/13/14 18:31, Eric Blake wrote:
>> The next patch will be adding tests; for ease of review of that
>> patch, I want to create common context lines that don't change
>> when the new tests are added (it's easier to visually review
>> additions than it is to review an entire chunk of tests rewritten
>> into another larger chunk of tests).
>>
>> * tests/virstoragetest.c (mymain): Add a parameter and renumber
>> the lookup tests.
> 
> Not entirely clear why the new parameter is needed, but gets clarified
> in the next patch.

I amended the commit message to mention the purpose of the new parameter...

> 
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>>  tests/virstoragetest.c | 79 +++++++++++++++++++++++++-------------------------
>>  1 file changed, 40 insertions(+), 39 deletions(-)
>>
> 
> ACK,

and pushed the series.  Thanks for the review.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140616/61b57ffd/attachment-0001.sig>


More information about the libvir-list mailing list