[libvirt] [PATCH v2 05/10] conf: alter disk mirror xml output

[Eric Blake]

On 06/06/2014 03:46 PM, Eric Blake wrote:
> On 06/06/2014 05:36 AM, Peter Krempa wrote:
>> On 06/06/14 00:52, Eric Blake wrote:
>>> Now that we track a disk mirror as a virStorageSource, we might
>>> as well update the XML to theoretically allow any type of
>>> mirroring destination (not just a local file).  A later patch
>>> will also be reusing <mirror> to track the block commit of the
>>> top layer of a chain, which is another case where libvirt needs
>>> to update the backing chain after the job is finally pivoted,
>>> and since backing chains can have network backing files as the
>>> destination to commit into, it makes more sense to display that
>>> in the XML.
>>>
> 
>>
>> ACK,
> 
> I made a minor tweak (in virDomainDiskDefFormat, I split the initial
> <mirror type='...' ready='...'> into two actions, per your comment on
> 9/10), and pushed this one.

On IRC, John pointed out that this change tripped up the libvirt
regression testsuite (so there IS code depending on the older <mirror
file='/path/to/file'/> notation), and danpb convinced me I need to
provide the older semantics even while adding newer semantics, so as not
to break older clients.  I'll be preparing a followup patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140616/1c1c098c/attachment-0001.sig>