[libvirt] [PATCH 3/3] Add pkg-config files to allow deps to build against source tree

[Daniel P. Berrange]

On Fri, Jun 20, 2014 at 01:02:46PM -0600, Eric Blake wrote:
> On 06/20/2014 10:51 AM, Daniel P. Berrange wrote:
> > When testing language bindings it is useful to be able to build
> > them against an uninstalled libvirt source tree. Add a dummy
> > set of pkg-config files to allow for this. This can be used by
> > setting
> > 
> >   export PKG_CONFIG_PATH=/path/to/libvirt/git/src
> 
> Yay - we need to document this trick in libvirt-python.git as well.
> 
> > 
> > Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> > ---
> >  .gitignore             |  1 +
> >  configure.ac           |  3 +++
> >  src/Makefile.am        |  8 +++++++-
> >  src/libvirt-lxc.pc.in  | 18 ++++++++++++++++++
> >  src/libvirt-qemu.pc.in | 18 ++++++++++++++++++
> >  src/libvirt.pc.in      | 23 +++++++++++++++++++++++
> >  6 files changed, 70 insertions(+), 1 deletion(-)
> >  create mode 100644 src/libvirt-lxc.pc.in
> >  create mode 100644 src/libvirt-qemu.pc.in
> >  create mode 100644 src/libvirt.pc.in
> > 
> 
> > +++ b/src/Makefile.am
> > @@ -45,7 +45,13 @@ AM_LDFLAGS =	$(DRIVER_MODULE_LDFLAGS)			\
> >  		$(NO_INDIRECT_LDFLAGS)				\
> >  		$(NULL)
> >  
> > -EXTRA_DIST = $(conf_DATA) util/keymaps.csv
> > +EXTRA_DIST = \
> > +		$(conf_DATA) \
> > +		util/keymaps.csv \
> > +		libvirt.pc \
> > +		libvirt-qemu.pc \
> > +		libvirt-lxc.pc \
> > +		$(NULL)
> 
> NACK to this hunk - the .pc files should NOT be part of the tarball,
> because they contain contents that depend on configure results, while
> the tarball must be independent.  End users will get their own .pc file
> as soon as they do ./configure && make.

Obviously that was meant to be the .pc.in files

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|