[libvirt] [PATCH v2 1/2] virtportallocator: new function "virPortAllocatorSetUsed"

Giuseppe Scrivano gscrivan at redhat.com
Tue Jun 24 12:04:53 UTC 2014


Michal Privoznik <mprivozn at redhat.com> writes:

> On 24.06.2014 13:34, Giuseppe Scrivano wrote:
>> virPortAllocatorSetUsed permits to set a port as already used and
>> prevent the port allocator to use it without any attempt to bind it.
>>
>> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>> ---
>>   src/libvirt_private.syms    |  1 +
>>   src/util/virportallocator.c | 44 +++++++++++++++++++++++++++++++++++++++++++-
>>   src/util/virportallocator.h |  4 ++++
>>   3 files changed, 48 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
>> index 2a2b9c0..95a45aa 100644
>> --- a/src/libvirt_private.syms
>> +++ b/src/libvirt_private.syms
>> @@ -1770,6 +1770,7 @@ virPidFileWritePath;
>>   virPortAllocatorAcquire;
>>   virPortAllocatorNew;
>>   virPortAllocatorRelease;
>> +virPortAllocatorSetUsed;
>>
>>
>>   # util/virprocess.h
>> diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c
>> index b68133a..226f386 100644
>> --- a/src/util/virportallocator.c
>> +++ b/src/util/virportallocator.c
>> @@ -1,7 +1,7 @@
>>   /*
>>    * virportallocator.c: Allocate & track TCP port allocations
>>    *
>> - * Copyright (C) 2013 Red Hat, Inc.
>> + * Copyright (C) 2013, 2014 Red Hat, Inc.
>
> How about 2013-2014?

>> +    else {
>

I've no write access to the repo.  Could these fixes be amended before
pushing the patches or shall I go for v3?

Thanks,
Giuseppe




More information about the libvir-list mailing list