[libvirt] [PATCH v4] Only set SELinux seclabel if supported by the host.

Christophe Fergeau cfergeau at redhat.com
Wed Jun 25 07:34:27 UTC 2014


On Wed, Jun 18, 2014 at 01:22:12PM +0200, Cedric Bosdonnat wrote:
> On Wed, 2014-06-18 at 11:11 +0200, Christophe Fergeau wrote:
> > > +static gboolean gvir_sandbox_builder_construct_security(GVirSandboxBuilder *builder,
> > > +                                                        GVirSandboxConfig *config,
> > > +                                                        const gchar *statedir G_GNUC_UNUSED,
> > > +                                                        GVirConfigDomain *domain,
> > > +                                                        GError **error)
> > > +{
> > > +    GVirConnection *connection = gvir_sandbox_builder_get_connection(builder);
> > > +    GVirConfigCapabilities *configCapabilities;
> > > +    GVirConfigCapabilitiesHost *hostCapabilities;
> > > +    GList *secmodels, *iter;
> > > +    gboolean supportsSelinux = FALSE;
> > > +
> > > +    /* What security models are available on the host? */
> > > +    if (!(configCapabilities = gvir_connection_get_capabilities(connection, error))) {
> > 
> > Missing g_object_unref(connection); here too.
> 
> Oops, I forgot that one case indeed.

I've pushed this patch with this missing _unref squashed in.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140625/cf47fb15/attachment-0001.sig>


More information about the libvir-list mailing list