[libvirt] [PATCHv3 10/26] util: storagefile: Add deep copy for struct virStorageSource

Eric Blake eblake at redhat.com
Wed Jun 25 23:15:26 UTC 2014


On 06/25/2014 10:54 AM, Peter Krempa wrote:
> Now that we have pointers to store disk source information and thus can
> easily exchange the structs behind we need a function to copy all the
> data.
> ---
>  src/libvirt_private.syms  |   1 +
>  src/util/virstoragefile.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++
>  src/util/virstoragefile.h |   3 +
>  3 files changed, 147 insertions(+)
> 

> +
> +
> +virStorageSourcePtr
> +virStorageSourceCopy(const virStorageSource *src,
> +                     bool backingChain)

Might be worth a doc comment for this function as well, mentioning that
driver metadata is not copied, and backingChain controls whether the
copy is shallow or deep with regards to backing files.

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140625/f449da11/attachment-0001.sig>


More information about the libvir-list mailing list