[libvirt] [PATCH] add option to enforce minimal pagesize for hugetlbfs backed guests

[Paolo Bonzini]

Il 11/02/2014 15:46, Daniel P. Berrange ha scritto:
> IMHO all of this code is something that belongs in QEMU, with libvirt
> telling QEMU what min page size it wants via a CLI arg.

I disagree.  QEMU just gets a path to something that doesn't even have 
to be a hugetlbfs mountpoint.  QEMU hardly needs to know the page size; 
it computes it in order to truncate the file size to an integer number 
of pages, but if that's required it sounds like a workaround for a bug 
in hugetlbfs.

In fact, I believe that even making a temporary file shouldn't belong in 
QEMU, and instead libvirt should just pass a filename or a file 
descriptor, but this would require changes in QEMU so it's left for 
another day.

Paolo