[libvirt] [PATCH] build: work around FreeBSD stdlib.h bug

[Roman Bogorodskiy]

  Eric Blake wrote:

> On 03/07/2014 10:09 AM, Daniel P. Berrange wrote:
> > On Fri, Mar 07, 2014 at 09:56:10AM -0700, Eric Blake wrote:
> >> On 03/04/2014 06:59 AM, Eric Blake wrote:
> >>> On 03/04/2014 06:47 AM, Daniel P. Berrange wrote:
> >>>> On Tue, Mar 04, 2014 at 06:28:17AM -0700, Eric Blake wrote:
> >>>>> POSIX requires that <stdlib.h> expose WIFEXITED and friends,
> >>>>> but FreeBSD and others fail to comply.  We can work around it
> >>>>> manually by including <sys/wait.h>, or we can work around it
> >>>>> automatically by using gnulib's system-posix module.
> >>>>>
> 
> >>> We already have a couple of helper functions, and my recent virFork
> >>> cleanups got rid of even more clients of WIFEXITED (that is,
> >>> virCommandRun now defaults to returning sanitized rather than raw exit
> >>> values).  At this point, there are very few reasons for any new code to
> >>> need to use WIFEXITED; it's mostly limited to existing code (but where
> >>> my virFork cleanups tripped up on the FreeBSD header bug due to
> >>> refactoring).
> >>>
> >>
> >> So, should I just ditch this patch?
> > 
> > I don't feel strongly either way. ACK if you thing it is worth doing
> > anyway.
> 
> Roman, any thoughts, since you are the person most likely impacted by
> this?  If we do the gnulib change, then future patches that assume POSIX
> semantics, and pass testing when written by developers against glibc,
> won't break the build on BSD; on the other hand, we've made virprocess.h
> useful enough that most future patches shouldn't be using WIFEXITED
> directly and therefore shouldn't trip up BSD compilation in the first
> place.  Meanwhile, do you want to file a bug report to the BSD folks to
> fix their <stdio.h>?

I think it's worth to include that patch because it costs nothing and
helps not to occasionally spot this problem again in future.

I'll make a bug report.

Thanks,

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140308/6db4ca3e/attachment-0001.sig>