[libvirt] [PATCH] Fix locking in virsh console

Roman Bogorodskiy bogorodskiy at gmail.com
Mon Mar 10 11:45:06 UTC 2014


  Daniel P. Berrange wrote:

> On Mon, Mar 10, 2014 at 03:04:15PM +0400, Roman Bogorodskiy wrote:
> > vshRunConsole() uses virCondWait() which is a wrapper around
> > pthread_cond_wait(). On FreeBSD, pthread_cond_wait needs mutex to be
> > locked, otherwise it immediately fails with EPERM. On Linux, the
> > behaviour in this case is undefined.
> > 
> > So lock the mutex before calling virCondWait().
> > ---
> >  tools/virsh-console.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> 
> ACK

Pushed, thanks!

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140310/f41bc4f4/attachment-0001.sig>


More information about the libvir-list mailing list