[libvirt] [PATCH] storage: Fix bugs in VIR_APPEND_ELEMENT series

[Eric Blake]

On 03/11/2014 01:54 PM, John Ferlan wrote:
>>From commit id 'd53bbfd1'
> 
> Found one core and one possible memory leak. Core seen during local
> virt-test/tp_libvirt run for the vol_create_from test. The memory leak
> was seen by inspection during a review of all VIR_APPEND_ELEMENT changes
> 
> In storage_backend_disk/virStorageBackendDiskMakeDataVol(), the 'vol'
> needs to be kept around since it's used later, so use the _COPY macro.
> This caused a segv in libvirtd:
> 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fffe87c3700 (LWP 6919)]
> virStorageBackendDiskMakeDataVol (vol=0x0, groups=0x7fffc8000d70, pool=0x7fffc8002460) at storage/storage_backend_disk.c:66
> 66          if (vol->target.path == NULL) {
> 
> In storage_backend_rbd/virStorageBackendRBDRefreshPool() there's a failure
> path where the 'vol' needs to go through virStorageVolDefFree() since it
> wouldn't be appended.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140311/9f510003/attachment-0001.sig>