[libvirt] [PATCH] qemu.conf: Mention virtlockd in @lock_manager description

[Eric Blake]

On 03/12/2014 01:59 AM, Michal Privoznik wrote:
> When I played with virtlockd I was stunned by lacking
> documentation. My frustration got bigger when I had to
> read the patches to get the correct value to set in
> qemu.conf.
> 
> Moreover, from pure libvirt-pride  I'm changing commented
> value from sanlock to lockd. We want to favor our own
> implementation after all.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu.conf | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
> index e436084..f0e802f 100644
> --- a/src/qemu/qemu.conf
> +++ b/src/qemu/qemu.conf
> @@ -402,11 +402,13 @@
>  #allow_disk_format_probing = 1
>  
>  
> -# To enable 'Sanlock' project based locking of the file
> -# content (to prevent two VMs writing to the same
> -# disk), uncomment this
> +# In order to prevent accidentally starting two domains that
> +# share one writable disk, libvirt offers two approaches for
> +# locking files. The first one is sanlock, the other one,
> +# virtlockd, is then our own implementation. Accepted values

I'm not sure about that wording of that sentence.  Maybe:

..offers two approaches for locking files: 'sanlock' uses the external
sanlock daemon, and 'virtlockd' is implemented as part of libvirt.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140312/bf791f06/attachment-0001.sig>