[libvirt] [PATCH 6/7 v2] Switch to filtering based on log source name instead of filename

Eric Blake eblake at redhat.com
Mon Mar 17 17:23:01 UTC 2014


On 03/10/2014 09:01 AM, Daniel P. Berrange wrote:
> Currently the log filter strings are used in a string comparison
> against the source filename each time log message is emitted.
> If no log filters at all are set, there's obviously no string
> comparison to be done. If any single log filter is set though,
> this imposes a compute burden on every logging call even if logs
> from the file in question are disabled. This string comparison
> must also be done while the logging mutex is held, which has
> implications for concurrency when multiple threads are emitting
> log messages.

> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/util/virlog.c | 83 ++++++++++++++++++++++++++-----------------------------
>  src/util/virlog.h |  6 ++++
>  2 files changed, 45 insertions(+), 44 deletions(-)
> 

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140317/0735bdfe/attachment-0001.sig>


More information about the libvir-list mailing list