[libvirt] [PATCH] Ignore char devices in storage pools by default

[Ján Tomko]

On 03/20/2014 05:45 PM, Eric Blake wrote:
> On 03/20/2014 10:08 AM, Ján Tomko wrote:
>> Without this, using /dev/mapper as a directory pool
>> fails in virStorageBackendUpdateVolTargetInfoFD:
>> cannot seek to end of file '/dev/mapper/control': Illegal seek
>>
>> Skip over character devices by default.
> 
> I agree that character devices can't serve as a storage volume.
> 
> It may still be nice to have storage pools express all file names,
> including those files that can't be volumes (dangling symlinks,
> character devices, named fifos or sockets) rather than its current
> filtering (regular files, block devices, directories, symlinks to one of
> the above).  Doing so would make storage pools become a way to do remote
> directory listings, for all types of files and not just storage volumes,
> which becomes handy for choosing new volume names (which should not
> conflict with existing files, even where the existing files cannot be a
> storage volume).  But that's a bigger change for a different day.
> 
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=710866
>> ---
>>  src/storage/storage_backend.h | 1 -
>>  1 file changed, 1 deletion(-)
> 
> ACK.
> 

Thanks, pushed now.

Jan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140320/e4716480/attachment-0001.sig>