[libvirt] [PATCH 3/3] Check boot order on device attach

Eric Blake eblake at redhat.com
Thu Mar 20 20:05:15 UTC 2014


On 03/20/2014 08:42 AM, Jiri Denemark wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1007754
> 
> When attaching a new device, we need to check if its boot order
> configuration is compatible with current domain definition.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/conf/domain_conf.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/conf/domain_conf.h |  1 +
>  2 files changed, 80 insertions(+)
> 

>  
> +virDomainDeviceInfoPtr
> +virDomainDeviceGetInfo(virDomainDeviceDefPtr device)
> +{

I probably would have split this helper function into its own patch - it
may be handy in other situations, where we might want to backport just
this function and a future use of it.  But the overall patch is small
enough that I don't mind keeping it as one patch to minimize your churn.

ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140320/073ac78c/attachment-0001.sig>


More information about the libvir-list mailing list