[libvirt] [PATCH 07/18] conf: use disk source accessors in lxc/

Laine Stump laine at laine.org
Fri Mar 21 19:10:28 UTC 2014


On 03/19/2014 11:20 AM, Eric Blake wrote:
> Part of a series of cleanups to use new accessor methods.
>
> * src/lxc/lxc_cgroup.c (virLXCCgroupSetupDeviceACL): Use
> accessors.
> * src/lxc/lxc_controller.c (virLXCControllerSetupLoopDeviceDisk)
> (virLXCControllerSetupNBDDeviceDisk)
> (virLXCControllerSetupLoopDevices, virLXCControllerSetupDisk):
> Likewise.
> * src/lxc/lxc_driver.c (lxcDomainAttachDeviceDiskLive)
> (lxcDomainDetachDeviceDiskLive): Likewise.
>
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/lxc/lxc_cgroup.c     |  6 ++---
>  src/lxc/lxc_controller.c | 69 +++++++++++++++++++++++++++---------------------
>  src/lxc/lxc_driver.c     | 27 +++++++++++--------
>  3 files changed, 58 insertions(+), 44 deletions(-)
>
> diff --git a/src/lxc/lxc_cgroup.c b/src/lxc/lxc_cgroup.c
> index 5a1718d..da5ccf5 100644
> --- a/src/lxc/lxc_cgroup.c
> +++ b/src/lxc/lxc_cgroup.c

>
> @@ -1662,12 +1671,12 @@ static int virLXCControllerSetupDisk(virLXCControllerPtr ctrl,
>      mode_t mode;
>      char *tmpsrc = def->src;

Why didn't you use the accessor here?





More information about the libvir-list mailing list