[libvirt] [PATCH tck] Change 'Sys::Virt::TCK::generic_domain' to take named params

[Mike Latimer]

On Thursday, March 27, 2014 02:49:11 PM Daniel P. Berrange wrote:
> To make it easier to add more optional parameters to the
> Sys::Virt::TCK::generic_domain method, change it to take
> named parameters instead of positional parameters.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  docs/writing-tests.pod                         |  6 ++---
>  lib/Sys/Virt/TCK.pm                            | 37
> +++++++++++++++----------- lib/Sys/Virt/TCK/NetworkHelpers.pm             |
>  2 +-
>  scripts/domain/050-transient-lifecycle.t       |  2 +-
>  scripts/domain/051-transient-autostart.t       |  2 +-
>  scripts/domain/060-persistent-lifecycle.t      |  2 +-
>  scripts/domain/061-persistent-autostart.t      |  2 +-
>  scripts/domain/065-persistent-redefine.t       |  2 +-
>  scripts/domain/070-transient-to-persistent.t   |  2 +-
>  scripts/domain/080-unique-id-define.t          |  8 +++---
>  scripts/domain/081-unique-id-create.t          |  8 +++---
>  scripts/domain/082-unique-id-caching.t         |  4 +--
>  scripts/domain/090-invalid-ops-when-inactive.t |  2 +-
>  scripts/domain/100-transient-save-restore.t    |  2 +-
>  scripts/domain/101-persistent-save-restore.t   |  2 +-
>  scripts/domain/102-broken-save-restore.t       |  2 +-
>  scripts/domain/103-blockdev-save-restore.t     |  2 +-
>  scripts/domain/120-disks-stats.t               |  2 +-
>  scripts/domain/121-block-info.t                |  2 +-
>  scripts/domain/130-cpu-hotplug.t               |  2 +-
>  scripts/domain/180-interface-parameters.t      |  2 +-
>  scripts/domain/200-disk-hotplug.t              |  2 +-
>  scripts/domain/202-numa-set-parameters.t       |  2 +-
>  scripts/domain/205-disk-hotplug-ordering.t     |  2 +-
>  scripts/domain/207-disk-media-change.t         |  2 +-
>  scripts/domain/210-nic-hotplug.t               |  2 +-
>  scripts/domain/215-nic-hotplug-many.t          |  2 +-
>  scripts/domain/240-usb-host-hotplug.t          |  2 +-
>  scripts/domain/250-pci-host-hotplug.t          |  2 +-
>  scripts/domain/300-migration.t                 |  2 +-
>  scripts/domain/301-migration-max-speed.t       |  2 +-
>  scripts/hooks/052-domain-hook.t                |  2 +-
>  scripts/qemu/100-disk-encryption.t             |  2 +-
>  scripts/qemu/200-qcow2-single-backing-file.t   |  2 +-
>  scripts/qemu/205-qcow2-double-backing-file.t   |  2 +-
>  scripts/qemu/210-qcow2-auto-probing.t          |  2 +-
>  scripts/qemu/400-save-image-xml.t              |  2 +-
>  scripts/selinux/050-dynamic-relabel-yes.t      |  2 +-
>  scripts/selinux/055-dynamic-base-label.t       |  2 +-
>  scripts/selinux/100-static-relabel-no.t        |  2 +-
>  scripts/selinux/105-static-relabel-fail.t      |  2 +-
>  scripts/selinux/110-static-relabel-yes.t       |  2 +-
>  42 files changed, 71 insertions(+), 66 deletions(-)

ACK. This seems like a good improvement, and works well in my testing.

-Mike