[libvirt] [PATCH] Expose SLIRP attributes

[Richard W.M. Jones]

On Fri, Mar 28, 2014 at 02:17:50PM +0200, Laine Stump wrote:
> On 03/28/2014 01:03 PM, Richard W.M. Jones wrote:
> > On Fri, Mar 28, 2014 at 12:16:43PM +0200, Laine Stump wrote:
> >> On 03/28/2014 10:47 AM, Richard W.M. Jones wrote:
> >>> On Fri, Mar 28, 2014 at 10:33:39AM +0200, Laine Stump wrote:
> >> * address should be mandatory
> > I don't understand why this should be mandatory.
[...]
> >  Actually I don't
> > think any of them should be mandatory (the same as qemu), but the only
> > one which libguestfs would specify is the network.  The guest can
> > choose any IP address on the network >= .5 and things will work.  The
> > libguestfs appliance arbitrarily uses .10 since DHCP would be too
> > slow.
> 
> But if the guest is going to choose an IP address itself rather than
> getting one from DHCP, it should know that it's choosing an address on
> the correct network, and I don't like the idea of depending on qemu's
> current choice of default network/host IP/dns IP to remain constant.

That's fair enough, although it seems unlikely it would change
especially as no one is really touching the SLIRP code beyond urgent
security fixes.

However I'm not clear if when you said "address should be mandatory"
you meant the network address or the guest DHCP start address.  It
seemed to me you meant the DHCP start address, but now I think perhaps
you meant the network address?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/