[libvirt] [PATCH 2/2] Prohibit Windows special chars in filenames

Matthias Bolte matthias.bolte at googlemail.com
Sat Mar 29 11:23:50 UTC 2014


Using any of these chars [:*?"<>|] in a filename is forbidden on
Windows and breaks git operations on Windows as git is not able
to create those files/directories on clone or pull.

Because some of them can be used in UNIX filenames they tend to
creep into filenames, especially : in PCI/SCSI device names that
are used as filenames in test cases.
---
 cfg.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/cfg.mk b/cfg.mk
index a4ae978..117584c 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -912,6 +912,11 @@ sc_curly_braces_style:
 			  'braces around function body, see'           \
 			  'HACKING' 1>&2; exit 1; } || :
 
+sc_prohibit_windows_special_chars_in_filename:
+	@files=$$($(VC_LIST_EXCEPT) | grep '[:*?"<>|]');               \
+	test -n "$$files" && { echo '$(ME): Windows special chars'     \
+	  'in filename not allowed:' 1>&2; echo $$files 1>&2; exit 1; } || :
+
 # We don't use this feature of maint.mk.
 prev_version_file = /dev/null
 
-- 
1.8.1.2




More information about the libvir-list mailing list