[libvirt] [PATCH 10/n] util: don't support loopback and nbd when setuid

Peter Krempa pkrempa at redhat.com
Mon Mar 31 08:31:41 UTC 2014


On 03/29/14 21:56, Eric Blake wrote:
> The only remaining reason that virt-login-shell was trying to
> link against virstoragefile was because of a call to
> virStorageFileFormatTypeToString when spawning a qemu-nbd
> process - but setuid processes shouldn't be spawning qemu-nbd.
> 
> * src/util/virfile.c (virFileLoopDeviceAssociate)
> (virFileNBDDeviceAssociate): Cripple in setuid builds.
> * src/Makefile.am (libvirt_setuid_rpc_client_la_SOURCES):
> Drop virstoragefile from the list.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/Makefile.am    | 1 -
>  src/util/virfile.c | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

ACK

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140331/d12cecb9/attachment-0001.sig>


More information about the libvir-list mailing list