[libvirt] [PATCH 13/n] conf: tweak volume target struct details

[Peter Krempa]

On 03/30/14 05:37, Eric Blake wrote:
> Some preparatory work before consolidating storage volume
> structs with the rest of virstoragefile.  Making these
> changes allows a volume target to be much closer to the
> virStorageSource struct.

While I don't think that the refactor of the target is a good idea ...

> 
> * src/conf/storage_conf.h (_virStorageVolTarget): Change perms to
> pointer, enhance comments.
> * src/conf/storage_conf.c (virStorageVolDefFree)
> (virStorageVolDefParseXML, virStorageVolTargetDefFormat): Update
> clients.
> * src/storage/storage_backend_fs.c (createFileDir): Likewise.
> * src/storage/storage_backend.c (virStorageBackendCreateBlockFrom)
> (virStorageBackendCreateRaw, virStorageBackendCreateExecCommand)
> (virStorageBackendUpdateVolTargetInfoFD): Likewise.
> * src/storage/storage_backend_logical.c
> (virStorageBackendLogicalCreateVol): Likewise.
> * src/storage/storage_backend_disk.c
> (virStorageBackendDiskMakeDataVol)
> (virStorageBackendDiskPartTypeToCreate): Likewise.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/conf/storage_conf.c               | 26 ++++++++++++------
>  src/conf/storage_conf.h               |  7 ++---
>  src/storage/storage_backend.c         | 50 ++++++++++++++++++++---------------
>  src/storage/storage_backend_disk.c    | 14 +++++-----
>  src/storage/storage_backend_fs.c      |  6 ++---
>  src/storage/storage_backend_logical.c |  6 ++---
>  6 files changed, 63 insertions(+), 46 deletions(-)
> 

... ACK to this patch

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140331/104091f1/attachment-0001.sig>