[libvirt] [PATCH V2 3/3] libxl: support PARAVIRT and ACPI reboot flags

[Jim Fehlig]

Daniel P. Berrange wrote:
> On Fri, May 02, 2014 at 08:01:00AM -0600, Jim Fehlig wrote:
>   
>> Daniel P. Berrange wrote:
>>     
>>> Given that Xen has a decent paravirt reboot facility I'd probably
>>> just not bother with trying to fake the controlled reboot via ACPI.
>>>   
>>>       
>> Ok, that sounds reasonable to me.  I'll drop this patch when pushing the
>> others, post 1.2.4.  Should 1/3 retain the VIR_DOMAIN_REBOOT_PARAVIRT
>> addition tovirDomainRebootFlagValues?
>>     
>
> I don't think you need to drop the patch/code. It is still useful, IMHO,
> to have the explicit flag for VIR_DOMAIN_REBOOT_PARAVIRT. I'd just
> suggest you remove the block of code for VIR_DOMAIN_REBOOT_ACPI_POWER_BTN
> impl in the reboot method.
>   

Just to clarify, do you mean changing this patch to the attached one?

Regards,
Jim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libxl-PARAVIRT-reboot-flag.patch
Type: text/x-patch
Size: 1529 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140502/19b407e8/attachment-0001.bin>