[libvirt] [PATCH v7 4/4] vbox_tmpl.c: Add function for undefining snapshot

[Daniel P. Berrange]

On Fri, Apr 18, 2014 at 11:51:34AM +0200, Yohan BELLEGUIC wrote:
> All snapshots information will be deleted from the vbox XML, but
> differencing disks will be kept so the user will be able to redefine the
> snapshot.
> ---
>  src/vbox/vbox_tmpl.c |  453 +++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 452 insertions(+), 1 deletion(-)
> 
> diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
> index f8667f6..c5b5074 100644
> --- a/src/vbox/vbox_tmpl.c
> +++ b/src/vbox/vbox_tmpl.c
> @@ -8347,7 +8347,443 @@ vboxDomainSnapshotDeleteTree(vboxGlobalData *data,
>      return ret;
>  }
>  

> +
> +    /*Registering the machine*/
> +    if (vboxSnapshotSaveVboxFile(snapshotMachineDesc, settingsFilepath) < 0) {
> +        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> +                       _("Unable to serialize the machine description"));
> +        goto cleanup;
> +    }
> +    rc = data->vboxObj->vtbl->OpenMachine(data->vboxObj,
> +                                     settingsFilePathUtf16,
> +                                     &machine);
> +    if (NS_FAILED(rc)) {
> +        virReportError(VIR_ERR_INTERNAL_ERROR, "%s %x"
> +                       , _("Unable to open Machine"), rc);

The ',' should be immediately following the arg, not on a new line

> +        goto cleanup;
> +    }
> +
> +    rc = data->vboxObj->vtbl->RegisterMachine(data->vboxObj, machine);
> +    if (NS_FAILED(rc)) {
> +        virReportError(VIR_ERR_INTERNAL_ERROR, "%s %x"
> +                       , _("Unable to register Machine"), rc);e

Same point.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|