[libvirt] [PATCH] vmx: Relax virtualHW.version check

Martin Kletzander mkletzan at redhat.com
Sun May 11 10:08:04 UTC 2014


On Sat, May 10, 2014 at 04:41:16PM +0200, Matthias Bolte wrote:
>The original implementation of the VMX config parser assumed that the
>virtualHW.version would have more influence on the content of the VMX
>file than it actually seems to have. It started with accepting only
>version 4. Additonal versions were added later without any additional

s/Additonal/Additional/

>changes in the parser itself. This suggests that the influence of the
>virtualHW.version on the content and format of the VMX file is small
>or non-existent.
>
>The parser worked without any changes across several virtualHW and
>vSphere versions. So instead of adding new virtualHW.version values to
>the parser as they come along, or adding an extra flag to allow unknown
>virtualHW.version values just relax the check to require version 4 or
>later.
>---
>
>This patch is meant as a alternative for this patch series:
>https://www.redhat.com/archives/libvir-list/2014-May/msg00122.html
>

ACK, totally agree, I was just afraid of suggesting something like
this :-)

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140511/54734810/attachment-0001.sig>


More information about the libvir-list mailing list