[libvirt] [PATCH v4 1/3] qemu: extract PCI handling structs

[Roman Bogorodskiy]

  Eric Blake wrote:

> On 05/13/2014 03:21 AM, Ján Tomko wrote:
> > On 05/11/2014 08:48 AM, Roman Bogorodskiy wrote:
> >> Introduce new files (domain_addr.[ch]) to provide
> >> an API for domain device handling that could be
> >> shared across the drivers.
> >>
> 
> 
> >> + * Author: Daniel P. Berrange <berrange at redhat.com>
> >> + */
> >> +
> > 
> > I think you should be the author, since you created the file.
> > Most of the structs and functions were (re)written by Laine anyway and we have
> > the copyrights and git history for attributions.
> > But I'd like to hear a second opinion on this.
> 
> Per-file authorship is an awkward concept in the age of multiple
> contributors. When copying and pasting from another file, I tend to
> preserve the original author if I used most of the code intact, or drop
> the line entirely if I'm going to do a rewrite.  The git log is much
> more authoratative than an author comment in the file, so I don't care
> enough to require you to change it - if you are comfortable claiming the
> work, put your own name.

Yes, as the change is mostly moving and renaming, I decided to keep the
original authorship as in the files I moved the code from. I think I'll
keep it as is then.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140513/3b8b65b9/attachment-0001.sig>