[libvirt] [PATCH] Managed-Save: False warning on successful managed save restoration

[Peter Krempa]

On 05/28/14 16:43, Eric Blake wrote:
> On 05/28/2014 02:45 AM, Peter Krempa wrote:
> 
>>>          }
>>
>> But this patch isn't ideal and makes the logic in the code even more entangled. 
>> qemuDomainObjRestore returns 1 on corrupted image that was removed, 0 on sucess 
>> and -1 on other errors. The condition right above that hunk tests success case. 
>> We should connect this failure case condition to the else section of that 
>> condition so that we don't make it even weirder.
> 
> Your approach is even more legible; consider this a pre-approved ACK if
> you turn it into a formal commit and apply it in time for 1.2.5.
> 

The fix is pushed now.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140528/8ad7e3f8/attachment-0001.sig>