[libvirt] [PATCH] UpdateDevice: Allow startupPolicy update
Peter Krempa
pkrempa at redhat.com
Wed Nov 5 15:29:08 UTC 2014
Add qemu: prefix to subject and mention that it's only with the _CONFIG
flag.
On 11/05/14 14:11, Michal Privoznik wrote:
> Users might want to update startupPolicy via the
> virDomainUpdateDeviceFlags API too. This patch
> implements the feature on config layer.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> src/qemu/qemu_driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 6acaea8..6fc15c0 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -7437,6 +7437,7 @@ qemuDomainUpdateDeviceConfig(virQEMUCapsPtr qemuCaps,
> if (disk->src->format)
> orig->src->format = disk->src->format;
> disk->src->path = NULL;
> + orig->startupPolicy = disk->startupPolicy;
Looks on par with what we are doing now. I wanted to comment that if you
don't specify a startup policy you might want to keep the existing one,
but the code does not use this approach, thus ...
> break;
>
> case VIR_DOMAIN_DEVICE_NET:
>
ACK with the subject tweaked
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141105/99bb634e/attachment-0001.sig>
More information about the libvir-list
mailing list