[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix a mismatch attribute name



On 11/07/2014 09:24 AM, Luyao Huang wrote:
>>From libvirt.org we know this attribute named:
> 
> interface_mac	MAC address of the network interface, not unique

Shouldn't we instead be fixing the docs to match the code?  Changing the
code now may break existing implementations that have used the name in
the current code.

> 
> Signed-off-by: Luyao Huang <lhuang redhat com>
> ---
>  src/access/viraccessdriverpolkit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/access/viraccessdriverpolkit.c b/src/access/viraccessdriverpolkit.c
> index 3136be7..0e07053 100644
> --- a/src/access/viraccessdriverpolkit.c
> +++ b/src/access/viraccessdriverpolkit.c
> @@ -206,7 +206,7 @@ virAccessDriverPolkitCheckInterface(virAccessManagerPtr manager,
>      const char *attrs[] = {
>          "connect_driver", driverName,
>          "interface_name", iface->name,
> -        "interface_macaddr", iface->mac,
> +        "interface_mac", iface->mac,
>          NULL,
>      };
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]