[libvirt] [PATCH] Fix a mismatch attribute name

lhuang lhuang at redhat.com
Fri Nov 7 09:37:45 UTC 2014


On 11/07/2014 05:15 PM, Eric Blake wrote:
> On 11/07/2014 09:24 AM, Luyao Huang wrote:
>> >From libvirt.org we know this attribute named:
>>
>> interface_mac	MAC address of the network interface, not unique
> Shouldn't we instead be fixing the docs to match the code?  Changing the
> code now may break existing implementations that have used the name in
> the current code.
yes, i agree with you, i give a v2 patch, but i don't know how to change 
the doc in http://libvirt.org.

https://www.redhat.com/archives/libvir-list/2014-November/msg00209.html

And this patch is for the bug:

https://bugzilla.redhat.com/show_bug.cgi?id=1161358
>> Signed-off-by: Luyao Huang <lhuang at redhat.com>
>> ---
>>   src/access/viraccessdriverpolkit.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/access/viraccessdriverpolkit.c b/src/access/viraccessdriverpolkit.c
>> index 3136be7..0e07053 100644
>> --- a/src/access/viraccessdriverpolkit.c
>> +++ b/src/access/viraccessdriverpolkit.c
>> @@ -206,7 +206,7 @@ virAccessDriverPolkitCheckInterface(virAccessManagerPtr manager,
>>       const char *attrs[] = {
>>           "connect_driver", driverName,
>>           "interface_name", iface->name,
>> -        "interface_macaddr", iface->mac,
>> +        "interface_mac", iface->mac,
>>           NULL,
>>       };
>>   
>>




More information about the libvir-list mailing list