[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/4] [RFE] introduce new vgamem attribute for video devices



On Mon, Nov 03, 2014 at 02:01:46PM +0100, Pavel Hrdina wrote:
This patch series fixes few issues with vram and ram attributes for video
devices and introduces new vgamem attribute to allow setting up video memory
size for QEMU video devices.


Well, we have 'vram' (old, always meant the size of the VGA memory),
then 'ram', that can be used only for 'qxl' (I don't quite understand
why we didn't just use the same value as 'vram', I doubt anyone is
using the parameter for what it was designed (secondary PCI BAR size,
was it?).  Adding yet another attribute that tries to control the same
parameter seems cumbersome.  Going over the documentation and patches,
this does not really cope with what libvirt tries to do.  Using
different attribute names depending on video model, and even
hypervisor, does remove the abstraction we're trying to preserve in
libvirt.

Does "ram" attribute do anything for qxl device?  Can't we just use
the attributes we have in XML and apply them properly to the devices
whilst preserving the abstraction?

Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]