[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] qemu: Don't try to parse -help for new QEMU



On 11/13/2014 01:39 PM, Jiri Denemark wrote:
> Since QEMU 1.2.0, we switched to QMP probing instead of parsing -help
> (and other commands, such as -cpu ?) output. However, if QMP probing
> failed, we still tried starting QEMU with various options and parsing
> the output, which was guaranteed to fail because the output changed.
> Let's just refuse parsing -help for QEMU >= 1.2.0.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1160318
> Signed-off-by: Jiri Denemark <jdenemar redhat com>
> ---
> 
> Notes:
>     Version 2:
>     - fixes comparison to avoid parsing -help for 1.2.0 (> vs >=)

ACK.

> 
>  src/qemu/qemu_capabilities.c             |  10 ++
>  tests/qemuhelpdata/qemu-kvm-1.2.0-device | 238 ------------------------------
>  tests/qemuhelptest.c                     | 246 ++-----------------------------
>  3 files changed, 24 insertions(+), 470 deletions(-)
>  delete mode 100644 tests/qemuhelpdata/qemu-kvm-1.2.0-device
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]