[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 20/22] bracket-spacing: Don't modify current line



On 11/13/2014 07:37 AM, Martin Kletzander wrote:
> In bracket-spacing.pl, the current $line is being modified in $data.
> That, however, spoils that $data for another check.  Introduce new
> $tmpdata variable that can be used for temporary modifications.  The
> difference between $data and $line is that $data are as much cleaned as
> possible from non-code blocks and these changes must be kept.
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  build-aux/bracket-spacing.pl | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)

ACK; this one should be safe to go in at any point.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]