[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] drvbhyve: Use boot-order for grub-bhyve boot device



On 13.11.2014 15:02, Conrad Meyer wrote:
On Thu, Nov 13, 2014 at 8:30 AM, Michal Privoznik <mprivozn redhat com> wrote:
I think we need to honor boot order for CD-ROMs too. I mean, if you have two CD-ROMS like this:

     <disk type='file' device='cdrom'>
       <driver name='file' type='raw'/>
       <source file='/tmp/freebsd1.iso'/>
       <target dev='hda' bus='sata'/>
       <boot order='2'/>
     </disk>
     <disk type='file' device='cdrom'>
       <driver name='file' type='raw'/>
       <source file='/tmp/freebsd2.iso'/>
       <target dev='hda' bus='sata'/>
       <boot order='1'/>
     </disk>

I agree. I think the patch should do so.


I'd expect to boot from /tmp/freebsd2.iso. Although, on the other hand, there's only onde device we can boot from, right? If that's the case, your code works too. Or am I just off the page?

Michal

Right. grub-bhyve only knows how to boot one device (as far as I
know). In that example it should pick freebsd2.iso.

Okay. You've answered my only concern. So ACKed & pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]