[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: Add tests for new blkdeviotune arguments



On 11/12/2014 04:16 PM, John Ferlan wrote:
> The recent commit to add support for block_set_io_throttle parameters
> from version 1.7 of qemu did not add any tests - this adds the tests
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  .../qemuxml2argv-blkdeviotune-max.args             | 12 +++++
>  .../qemuxml2argv-blkdeviotune-max.xml              | 51 ++++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  3 ++
>  3 files changed, 66 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune-max.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune-max.xml
> 

> +      <source dev='/dev/HostVG/QEMUGuest2'/>
> +      <target dev='hdb' bus='ide'/>
> +      <iotune>
> +        <read_bytes_sec>5000</read_bytes_sec>
> +        <write_bytes_sec>5000</write_bytes_sec>
> +        <read_iops_sec>3500</read_iops_sec>
> +        <write_iops_sec>3500</write_iops_sec>
> +        <read_bytes_sec_max>5000</read_bytes_sec_max>
> +        <write_bytes_sec_max>5000</write_bytes_sec_max>
> +        <read_iops_sec_max>3500</read_iops_sec_max>
> +        <write_iops_sec_max>3500</write_iops_sec_max>

It would be nicer to use different values for different options, but coverity
already found the copy and paste error :)

Jan

> +        <size_iops_sec>2000</size_iops_sec>
> +      </iotune>
> +      <address type='drive' controller='0' bus='0' target='0' unit='1'/>
> +    </disk>
> +    <controller type='usb' index='0'/>
> +    <controller type='ide' index='0'/>
> +    <controller type='pci' index='0' model='pci-root'/>
> +    <memballoon model='virtio'/>
> +  </devices>
> +</domain>


Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]