[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v2 0/4] use the 'vram' attribute for QEMU video devices



There are some changes from the first version. We will not have a new 'vgamem'
attribute for video devices because we can use the 'vram' attribute. So far
for QEMU the 'vram' is used only to set the secondary ram for QXL which seems
to be correct as the secondary ram is used for pixmaps and surfaces.

The 'vgamem_mb' parameter for QXL sets the VGA framebuffer size, but the VGA
mode in QXL is used only as fallback if the OS doesn't have any QXL drivers
or before the drivers are loaded. The VGA framebuffer is part of the first ram
for QXL and for that we have 'ram' attribute. The rest of the first ram is
memory for rendering commands and it's data. Default VGA framebuffer size is
8MB which is sufficient.

Other QEMU video devices have only 'vgamem_mb' parameter and we will use the
'vram' attribute to set the size of video memory as it's used also for other
hypervisors.

The first two patches clean the usage of vram attribute and improve the
documentation and the rest two patches implements usage of 'vram' attribute
for remaining QEMU video devices.

Pavel Hrdina (4):
  video: cleanup usage of vram attribute and update documentation
  qxl: fix setting ram and vram values for qemu qxl device
  caps: introduce new qemu capability for vgamem_mb device property
  qemu-command: introduce new vgamem attribute for video devices

 docs/formatdomain.html.in                          |  62 +++++++-----
 src/conf/domain_conf.c                             |  19 +++-
 src/conf/domain_conf.h                             |   3 +-
 src/qemu/qemu_capabilities.c                       |  25 +++++
 src/qemu/qemu_capabilities.h                       |   3 +
 src/qemu/qemu_command.c                            |  44 ++++++++-
 tests/qemucapabilitiesdata/caps_1.2.2-1.caps       |   2 +
 tests/qemucapabilitiesdata/caps_1.2.2-1.replies    | 100 +++++++++++++++++--
 tests/qemucapabilitiesdata/caps_1.3.1-1.caps       |   3 +
 tests/qemucapabilitiesdata/caps_1.3.1-1.replies    | 108 +++++++++++++++++++--
 tests/qemucapabilitiesdata/caps_1.4.2-1.caps       |   3 +
 tests/qemucapabilitiesdata/caps_1.4.2-1.replies    | 108 +++++++++++++++++++--
 tests/qemucapabilitiesdata/caps_1.5.3-1.caps       |   3 +
 tests/qemucapabilitiesdata/caps_1.5.3-1.replies    | 108 +++++++++++++++++++--
 tests/qemucapabilitiesdata/caps_1.6.0-1.caps       |   3 +
 tests/qemucapabilitiesdata/caps_1.6.0-1.replies    | 108 +++++++++++++++++++--
 tests/qemucapabilitiesdata/caps_1.6.50-1.caps      |   3 +
 tests/qemucapabilitiesdata/caps_1.6.50-1.replies   | 108 +++++++++++++++++++--
 tests/qemucapabilitiesdata/caps_2.1.1-1.caps       |   3 +
 tests/qemucapabilitiesdata/caps_2.1.1-1.replies    | 108 +++++++++++++++++++--
 .../qemuxml2argv-graphics-spice-compression.args   |   2 +-
 .../qemuxml2argv-graphics-spice-sasl.args          |   4 +-
 .../qemuxml2argv-graphics-spice.args               |   4 +-
 .../qemuxml2argv-pcihole64-q35.args                |   2 +-
 tests/qemuxml2argvdata/qemuxml2argv-q35.args       |   2 +-
 .../qemuxml2argv-video-qxl-device-vgamem.args      |   6 ++
 .../qemuxml2argv-video-qxl-device-vgamem.xml       |  29 ++++++
 .../qemuxml2argv-video-qxl-device.args             |   6 ++
 .../qemuxml2argv-video-qxl-device.xml              |  29 ++++++
 .../qemuxml2argv-video-qxl-nodevice.args           |   5 +
 .../qemuxml2argv-video-qxl-nodevice.xml            |  29 ++++++
 .../qemuxml2argv-video-qxl-sec-device-vgamem.args  |   8 ++
 .../qemuxml2argv-video-qxl-sec-device-vgamem.xml   |  32 ++++++
 .../qemuxml2argv-video-qxl-sec-device.args         |   7 ++
 .../qemuxml2argv-video-qxl-sec-device.xml          |  32 ++++++
 .../qemuxml2argv-video-qxl-sec-nodevice.xml        |  32 ++++++
 .../qemuxml2argv-video-vga-device-vgamem.args      |   6 ++
 .../qemuxml2argv-video-vga-device-vgamem.xml       |  29 ++++++
 .../qemuxml2argv-video-vga-device.args             |   6 ++
 .../qemuxml2argv-video-vga-device.xml              |  29 ++++++
 .../qemuxml2argv-video-vga-nodevice.args           |   5 +
 .../qemuxml2argv-video-vga-nodevice.xml            |  29 ++++++
 tests/qemuxml2argvtest.c                           |  16 +++
 tools/virsh-domain.c                               |   4 +-
 44 files changed, 1188 insertions(+), 89 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-device-vgamem.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-device-vgamem.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-device.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-device.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-nodevice.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-nodevice.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-sec-device-vgamem.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-sec-device-vgamem.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-sec-device.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-sec-device.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-sec-nodevice.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-vga-device-vgamem.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-vga-device-vgamem.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-vga-device.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-vga-device.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-vga-nodevice.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-vga-nodevice.xml

-- 
2.0.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]