[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 4/4] qemu-command: introduce new vgamem attribute for video devices



On 11/17/2014 08:48 AM, Gerd Hoffmann wrote:
   Hi,

We cannot just start enforcing that the vram attribute should be power
of 2. We can ether silently modify the value from user to power of 2 or
let QEMU round the value up to nearest power of 2 value and just add
a note about this to documentation.

How about simply ignoring vram in case it has a invalid value?  This way
current behavior is maintained for existing xml files (not pass anything
and let qemu use the defaults).

Whenever libvirt applies fixups to the xml (like adding pci controllers
to old xml configs, as done on "virsh edit" for example) libvirt can
also fixup vram to have a valid value.

cheers,
   Gerd



Yes, fix the value to the next higher power of 2 is a solution. I've
checked the QEMU source code and it's done on your part since the vgamem
anyway so it's probable safe to do it also on our side for QEMU.

Pavel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]