[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix crash in tunnelled migration



On 11/20/14 13:27, Jiri Denemark wrote:
> Any attempt to start a tunnelled migration with libvirtd that supports
> RDMA migration (specifically commit v1.2.8-226-ged22a47) crashes
> libvirtd on the destination host.
> 
> The crash is inevitable because qemuMigrationPrepareAny is always called
> with NULL protocol in case of tunnelled migration.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1147331
> Signed-off-by: Jiri Denemark <jdenemar redhat com>
> ---
>  src/qemu/qemu_migration.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 100600e..89313df 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -2707,7 +2707,7 @@ qemuMigrationPrepareAny(virQEMUDriverPtr driver,
>                                         QEMU_MIGRATION_COOKIE_NBD)))
>          goto cleanup;
>  
> -    if (STREQ(protocol, "rdma") && !vm->def->mem.hard_limit) {
> +    if (STREQ_NULLABLE(protocol, "rdma") && !vm->def->mem.hard_limit) {
>          virReportError(VIR_ERR_OPERATION_INVALID, "%s",
>                         _("cannot start RDMA migration with no memory hard "
>                           "limit set"));
> 

ACK,

Peter

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]