[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: don't log failure when older iptables lacks -w



On 11/20/2014 12:38 AM, Peter Krempa wrote:
> On 11/20/14 00:21, Eric Blake wrote:
>> Commit dc33e6e4 caused older platforms like Fedora 20 to emit
>> scary log messages at startup:
>>
>> 2014-11-19 23:12:58.800+0000: 28906: error : virCommandWait:2532 : internal error: Child process (/usr/sbin/iptables -w -L -n) unexpected exit status 2: iptables v1.4.19.1: unknown option "-w"
>> Try `iptables -h' or 'iptables --help' for more information.
>>
>> Since we are probing and expect to handle the case where -w is not
>> supported, we should not let virCommand log it as an error.
>>
>> * src/util/virfirewall.c (virFirewallCheckUpdateLock): Handle
>> non-zero status ourselves.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>  src/util/virfirewall.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]